On Mon, Oct 16, 2023 at 07:40:03AM +0200, Jiri Slaby wrote: > On 15. 10. 23, 19:10, Cameron Williams wrote: > > Add support for additional revisions/IDs of the Brainboxes UC > > range of serial cards. > > > > Add: Additional UC-235/UC-246, UC-302, UC-313, UC-346, UC-357 card IDs > > Add: UC-253/UC-734 , UC-607, UC-836 cards > > Fix: UC-431 variant note removed as it is a 3-port card, and there is > > no generic 3-port configuration available. > > So can it be fixed instead of removed? > By fixed, do you mean implement a generic 3-port configuration? I could look into it, it would be nice to have all of the cards in the range supported, but I wanted to avoid adding a specific configuration only used by one niche card. If you mean fixed as in change the wording a little bit and add a Fixes: tag, then I can do that too. > > Fix: UC-257 moved to parport_serial as it is a serial/LPT card. > > So this patch deserves a Fixes tag and should go to stable as well? > > Anyway, could you split this into fixes and additions (ie. 2 patches)? > Noted. > thanks, > -- > js > suse labs >
