Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c

To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Crescent CY Hsieh <crescentcy.hsieh@xxxxxxxx>
Subject: Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c
From: Jiri Slaby <jirislaby@xxxxxxxxxx>
Date: Tue, 3 Oct 2023 11:49:22 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx
In-reply-to: <2023100305-gentleman-surging-a65c@gregkh>
References: <20231002015702.30509-1-crescentcy.hsieh@moxa.com> <20231002015702.30509-2-crescentcy.hsieh@moxa.com> <68d533d5-dbc8-4be3-a1fc-b3dd28b8f9df@kernel.org> <ZRvAG5336KxuugVd@moxa-ThinkCentre-M90t> <2023100305-gentleman-surging-a65c@gregkh>
User-agent: Mozilla Thunderbird

On 03. 10. 23, 9:30, Greg KH wrote:

Should I put these macros into pci_ids.h? If so, I am willing to help
relocate all other macros.


Please do not add new defines to pci_ids.h unless they are needed in
multiple files.


(Which VENDOR_MOXA is, but DEVICE ids are not.)


--
js
suse labs

References:
- [PATCH 0/4] tty: serial: 8250: Changes of MOXA PCIe boards in 8250_pci.c
  - From: Crescent CY Hsieh
- [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c
  - From: Crescent CY Hsieh
- Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c
  - From: Jiri Slaby
- Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c
  - From: Crescent CY Hsieh
- Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c
  - From: Greg KH