Hi Crescent, kernel test robot noticed the following build errors: [auto build test ERROR on tty/tty-testing] [also build test ERROR on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.6-rc4 next-20230929] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Crescent-CY-Hsieh/tty-serial-8250-Cleanup-MOXA-configurations-in-8250_pci-c/20231002-095945 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing patch link: https://lore.kernel.org/r/20231002015702.30509-5-crescentcy.hsieh%40moxa.com patch subject: [PATCH 4/4] tty: serial: 8250: Add support for MOXA PCIe boards to switch interface between RS422/RS485 config: alpha-defconfig (https://download.01.org/0day-ci/archive/20231002/202310021306.ewtlC1QY-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231002/202310021306.ewtlC1QY-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310021306.ewtlC1QY-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/tty/serial/8250/8250_pci.c: In function 'pci_moxa_setup': >> drivers/tty/serial/8250/8250_pci.c:2010:50: error: 'SER_RE422_ENABLED' undeclared (first use in this function); did you mean 'SER_RS422_ENABLED'? 2010 | port->port.rs485.flags = SER_RE422_ENABLED; | ^~~~~~~~~~~~~~~~~ | SER_RS422_ENABLED drivers/tty/serial/8250/8250_pci.c:2010:50: note: each undeclared identifier is reported only once for each function it appears in vim +2010 drivers/tty/serial/8250/8250_pci.c 1990 1991 static int pci_moxa_setup(struct serial_private *priv, 1992 const struct pciserial_board *board, 1993 struct uart_8250_port *port, 1994 int idx) 1995 { 1996 struct pci_dev *dev = priv->dev; 1997 unsigned short device = dev->device; 1998 unsigned int bar = FL_GET_BASE(board->flags); 1999 int offset; 2000 2001 /* 2002 * For the device IDs of MOXA PCIe boards match the pattern 0x*3** and 0x*1**, 2003 * these boards support switching interface between RS422/RS485 using TIOCSRS485. 2004 */ 2005 if ((device & 0x0F00) == 0x0100 || (device & 0x0F00) == 0x0300) { 2006 port->port.rs485_config = pci_moxa_rs485_config; 2007 port->port.rs485_supported = pci_moxa_rs485_supported; 2008 2009 if ((device & 0x0F00) == 0x0300) > 2010 port->port.rs485.flags = SER_RE422_ENABLED; 2011 } 2012 if (board->num_ports == 4 && idx == 3) 2013 offset = 7 * board->uart_offset; 2014 else 2015 offset = idx * board->uart_offset; 2016 2017 return setup_port(priv, port, bar, offset, 0); 2018 } 2019 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
