On 29.09.23 07:51, Greg KH wrote: > On Fri, Sep 29, 2023 at 12:12:46AM +0200, Lino Sanfilippo wrote: >> From: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> >> >> If the imx driver cannot support RS485 it sets the UARTS rs485_supported >> structure to NULL. But it still calls uart_get_rs485_mode() which may set >> the RS485_ENABLED flag. >> The flag however is evaluated by the serial core in uart_configure_port() >> at port startup and thus may lead to an attempt to configure RS485 even if >> it is not supported. >> >> Avoid this by calling uart_get_rs485_mode() only if RS485 is actually >> supported by the driver. Remove also a check for an error condition >> that is not possible any more now. >> >> Signed-off-by: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> >> --- >> drivers/tty/serial/imx.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) > > Why is this patch not marked for stable? > Right, it should be, I will correct this, thanks!
