On Wed, Sep 20, 2023 at 03:03:02PM -0400, Matthew Howell wrote: > > From: Matthew Howell <matthew.howell@xxxxxxxxxxxx> > > Sealevel XR17V35X based cards utilize DTR to control RS-485 Enable, but > the current implementation of 8250_exar uses RTS for the auto-RS485-Enable > mode of the XR17V35X UARTs. This patch implements DTR Auto-RS485 on > Sealevel cards. If you address the following couple of things, feel free to add Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> ... > Hopefully Alpine threads correctly this time Nope. ... > +static int sealevel_rs485_config(struct uart_port *port, struct ktermios *termios, > + struct serial_rs485 *rs485) Misindented second line (missing one space?). ... > + ret = generic_rs485_config(port, termios, rs485); > + Unneeded blank line. > + if (ret) > + return ret; -- With Best Regards, Andy Shevchenko
