* Jiri Slaby <jirislaby@xxxxxxxxxx> [230914 05:43]: > On 12. 09. 23, 13:03, Tony Lindgren wrote: > > +/* > > + * The "console=" option is handled by console_setup() in printk. We can't use > > + * early_param() as do_early_param() checks for "console" and "earlycon" options > > + * so console_setup() potentially handles console also early. Use parse_args(). > > So why not concentrate console= handling on one place, ie. in > console_setup()? The below (second time console= handling) occurs quite > illogical to me. Well console_setup() knows nothing about the probing serial port controller device, tries to call __add_preferred_console() based on a few hardcoded device names and some attempted guessing, and is stuffed into printk.c :) I don't think we should pile on more stuff into printk.c for this. If we wanted to do something, let's set up the console list somewhere else, and then just have console_setup() add every console option to that list and leave the rest of console_setup in place to avoid breaking things all over the place. Then we can export some find_named_console() type function for serial core to use. Or do you have some better ideas in mind? Regards, Tony
