* Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> [230912 15:07]:
> On Tue, Sep 12, 2023 at 02:03:44PM +0300, Tony Lindgren wrote:
> > +static LIST_HEAD(serial_base_consoles);
>
> Don't you need a locking to access this list?
> If not, perhaps a comment why it's okay?
It's updated at arch_initcall() time only, I'll add a comment.
> > + port_match = kasprintf(GFP_KERNEL, "%s:%i.%i", dev_name(port->dev),
> > + port->ctrl_id, port->port_id);
>
> What about starting using cleanup.h?
OK seems to simplify things nicely :)
> > +EXPORT_SYMBOL_GPL(serial_base_add_preferred_console);
>
> Can we use (start using) namespaced exports?
Sorry forgot about the namespace stuff already..
> ...
>
> > +static int __init serial_base_add_con(char *name, char *opt)
>
> const name
> const opt
> ?
For name yes, opt has issues as noted in the first patch in this
series.
> > + opt = strchr(val, ',');
> > + if (opt) {
> > + opt[0] = '\0';
> > + opt++;
> > + }
>
> strsep() ?
>
> Actually param_array() uses strcspn() in similar situation.
OK I'll change to use strcspn().
> > + if (!strlen(val))
> > + return 0;
>
> Btw, have you seen lib/cmdline.c? Can it be helpful here?
I don't think so as at this point we don't have param=value
pairs and param is the port name.
Will fix up the rest of the stuff you commented too thanks.
Regards,
Tony
