* Matthew Howell <matthew.howell@xxxxxxxxxxxx> [230901 18:48]:
> On Fri, 1 Sep 2023, Tony Lindgren wrote:
> > * Matthew Howell <matthew.howell@xxxxxxxxxxxx> [230831 14:58]:
> > > On Tue, 29 Aug 2023, Tony Lindgren wrote:
> > > > If it is a port_id conflict I'm not sure why commit 3d9e6f556e23 is not
> > > > working for your as it has commit a4a79e03bab5 ("serial: core: Revert
> > > > port_id use"). Care to check that again, or maybe try with v6.5 with just
> > > > the commit below reverted?
> > > >
> > > > 04c7f60ca477 ("serial: core: Fix serial core port id, including multiport devices")
> > >
> > > Just tried that, but no difference. Same error.
> >
> > OK thanks to testing it. So it's starting to look like the issue is
> > somehow related to the serial8250_setup_port() change in commit d962de6ae51f
> > ("serial: core: Fix serial core port id to not use port->line").
> >
> > The experimental patch below should confirm if the issue is related to the
> > port_id usage or serial8250_setup_port(). Care to give this a try against
> > v6.5 without other patches?
>
> For some reason I am unable to apply the patch using either git apply or
> the patch command. I made the change manually though and the issue still
> occurs.
OK. If the patch did not apply against v6.5, can you please verify you don't
have other patches applied like your revert? I don't think the patch I sent
is white space damanged or anything. Doing git diff v6.5.. should show you
what might be different :)
> > > > Dmesg output might help also to figure out if this happens on the first
> > > > port or the second port.
> > >
> > > The full error in dmesg is:
> > > [Aug30 15:48] exar_serial 0000:04:00.0: Couldn't register serial port 0, irq 24, type 2, error -22
> > >
> > > This is on a 2-port adapter. I don't see any indication in dmesg that it
> > > attempted to register the other port.
> >
> > OK. Are there other 8520 related uarts probing before that?
>
> Not that I can see. The only earlier entries I see are from before I load
> the patched driver. If I add another card in I can see that both are
> probed, but both have the error:
>
> [ +0.005929] exar_serial 0000:01:00.0: Couldn't register serial port 0,
> irq 24, type 2, error -22
> [ +0.003431] exar_serial 0000:04:00.0: Couldn't register serial port 0,
> irq 25, type 2, error -22
>
> 04:00.0 is a Sealevel card and the other is a reference Exar XR17V352.
Not sure what you mean with the 8250 entries from before loading the
patched driver..
Maybe things go wrong already somewhere earlier if the integrated 8250
port(s) don't show up either? If so, maybe this issue is somehow machine
specific rather than 8250_exar specific.
Can you please post or email me your full working dmesg output, failing
dmesg output, the kernel .config used, and kernel command line?
Also, do you have any suggestions for a commonly available pcie 8250_exar
card I could try to reproduce this issue with?
Regards,
Tony
