On Thu, Aug 31, 2023 at 12:33:33PM -0600, Dan Raymond wrote: > On 8/31/2023 12:08 PM, Andy Shevchenko wrote: > > Warning: This email is from an unusual correspondent. > > Warning: Make sure this is someone you trust. > > > > On Thu, Aug 24, 2023 at 02:59:01PM -0600, Dan Raymond wrote: > >> Implement a UART register tracing facility using the debugfs. This can be > >> used as a "serial port sniffer" to monitor UART traffic and line settings > >> with timestamps at microsecond granularity. This can be useful for general > >> serial port debugging or to debug the UART driver itself. > > > >> drivers/tty/serial/8250/8250_debug.c | 530 +++++++++++++++++++++++++++ > > > > My gosh. Why trace points and trace events can't be used for that? > > > > I don't understand your post. Are you saying there is already a way to > trace UART register reads/writes without this patch? Can you elaborate? By adding trace points and trace events, instead of a custom api like you did. I asked you to look into this already :) thanks, greg k-h