On Thu, Aug 24, 2023 at 12:25:16AM -0600, Dan Raymond wrote:
> Implement a UART register tracing facility using the debugfs. This can be
> used as a "serial port sniffer" to monitor UART traffic and line settings
> with timestamps at microsecond granularity. This can be useful for general
> serial port debugging or to debug the UART driver itself.
>
> Signed-off-by: Dan Raymond<draymond@xxxxxxxxxxxxx>
>
> ---
>
> diff -uprN -X a/Documentation/dontdiff a/Documentation/trace/index.rst
> b/Documentation/trace/index.rst
> --- a/Documentation/trace/index.rst 2022-11-16 02:04:15.000000000 -0700
> +++ b/Documentation/trace/index.rst 2023-08-23 21:40:33.641219700 -0600
> @@ -33,3 +33,4 @@ Linux Tracing Technologies
> coresight/index
> user_events
> rv/index
> + serial
> diff -uprN -X a/Documentation/dontdiff a/Documentation/trace/serial.rst
> b/Documentation/trace/serial.rst
> --- a/Documentation/trace/serial.rst 1969-12-31 17:00:00.000000000 -0700
> +++ b/Documentation/trace/serial.rst 2023-08-23 21:40:31.260358900 -0600
> @@ -0,0 +1,5 @@
> +UART Tracing
>
> +------------
>
> +
>
> +.. kernel-doc:: drivers/tty/serial/8250/8250_debug.c
>
> + :doc: UART register tracing
>
> diff -uprN -X a/Documentation/dontdiff a/drivers/tty/serial/8250/8250.h
> b/drivers/tty/serial/8250/8250.h
> --- a/drivers/tty/serial/8250/8250.h 2022-11-16 02:04:15.000000000 -0700
> +++ b/drivers/tty/serial/8250/8250.h 2023-08-23 17:04:43.171074700 -0600
> @@ -403,3 +403,11 @@ static inline int serial_index(struct ua
> {
> return port->minor - 64;
> }
> +
> +#ifdef CONFIG_SERIAL_8250_DEBUG
> +extern void uart_debug_create(struct uart_port *port);
> +extern void uart_debug_destroy(struct uart_port *port);
> +#else
> +static inline void uart_debug_create(struct uart_port *port) { }
> +static inline void uart_debug_destroy(struct uart_port *port) { }
> +#endif
> diff -uprN -X a/Documentation/dontdiff a/drivers/tty/serial/8250/8250_core.c
> b/drivers/tty/serial/8250/8250_core.c
> --- a/drivers/tty/serial/8250/8250_core.c 2022-11-16 02:04:15.000000000
> -0700
> +++ b/drivers/tty/serial/8250/8250_core.c 2023-08-21 16:16:47.502740700
> -0600
Your patch is somehow whitespace damaged with tabs stripped out and
line-wrapped :(
And you forgot to document what changed, here's what my bot says:
--------
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
and can not be applied. Please read the file,
Documentation/process/email-clients.rst in order to fix this.
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
