From: Jiri Slaby > Sent: Wednesday, August 16, 2023 7:47 AM > > On 15. 08. 23, 19:22, Nathan Chancellor wrote: > > On Thu, Aug 10, 2023 at 11:15:08AM +0200, Jiri Slaby (SUSE) wrote: > >> Unify the type of tty_operations::write() counters with the 'count' > >> parameter. I.e. use size_t for them. > >> > >> This includes changing constants to UL to keep min() and avoid min_t(). > > > > This patch appears to cause a warning/error on 32-bit architectures now > > due to this part of the change, as size_t is 'unsigned int' there: > > Right, this is my brain fart thinking ulong is the same as size_t > everywhere. No, size_t is uint on 32bit. > > I will fix this -- kernel build bot seems to be slow -- it didn't find > the issue out in my queue, nor in tty-testing. 'Vote up' my patches to minmax.h that make this all work. Then it won't care provided both values have the same signedness. (or, with patch 5, are non-negative 31bit compile time constants.) Pretty much the only other patch is casting the constants to (size_t). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
