On Thu, 10 Aug 2023, Jiri Slaby (SUSE) wrote:
> This makes all those 'unsigned char's an explicit 'u8'. This is part of
> the continuing unification of chars and flags to be consistent u8.
>
> This approaches tty_port_default_receive_buf(). Flags to be next.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Cc: William Hubbs <w.d.hubbs@xxxxxxxxx>
> Cc: Chris Brannon <chris@xxxxxxxxxxxxxxxx>
> Cc: Kirk Reiser <kirk@xxxxxxxxxx>
> Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Max Staudt <max@xxxxxxxxx>
> Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>
> Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andreas Koensgen <ajk@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>
> Cc: Matt Johnston <matt@xxxxxxxxxxxxxxxxxxxx>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxxx>
> Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>
> ---
> drivers/accessibility/speakup/spk_ttyio.c | 5 ++--
> drivers/input/serio/serport.c | 5 ++--
> drivers/misc/ti-st/st_core.c | 2 +-
> drivers/net/can/can327.c | 2 +-
> drivers/net/can/slcan/slcan-core.c | 5 ++--
> drivers/net/hamradio/6pack.c | 4 ++--
> drivers/net/hamradio/mkiss.c | 2 +-
> drivers/net/mctp/mctp-serial.c | 3 +--
> drivers/net/ppp/ppp_async.c | 8 +++----
> drivers/net/ppp/ppp_synctty.c | 11 ++++-----
> drivers/net/slip/slip.c | 2 +-
> drivers/tty/n_gsm.c | 2 +-
> drivers/tty/n_hdlc.c | 2 +-
> drivers/tty/n_tty.c | 28 +++++++++++------------
> drivers/tty/tty.h | 2 +-
> drivers/tty/tty_buffer.c | 21 ++++++++---------
> include/linux/tty_buffer.h | 4 ++--
> include/linux/tty_flip.h | 22 ++++++++----------
> include/linux/tty_ldisc.h | 18 +++++++--------
> sound/soc/codecs/cx20442.c | 4 ++--
> sound/soc/ti/ams-delta.c | 2 +-
> 21 files changed, 73 insertions(+), 81 deletions(-)
> diff --git a/include/linux/tty_buffer.h b/include/linux/tty_buffer.h
> index 6ceb2789e6c8..6f2966b15093 100644
> --- a/include/linux/tty_buffer.h
> +++ b/include/linux/tty_buffer.h
> @@ -22,9 +22,9 @@ struct tty_buffer {
> unsigned long data[];
> };
>
> -static inline unsigned char *char_buf_ptr(struct tty_buffer *b, int ofs)
> +static inline u8 *char_buf_ptr(struct tty_buffer *b, int ofs)
> {
> - return ((unsigned char *)b->data) + ofs;
> + return ((u8 *)b->data) + ofs;
> }
Any particular reason why b->data is left unsigned long?
--
i.
