On Tue, Aug 08, 2023 at 11:31:06AM +0800, Wenhua Lin wrote: > Automatic calculation through matching nodes, > subsequent projects can avoid modifying driver files. You sent three patches which has to be meant a series in three independent (unlinked) messages. Do not forget to use --thread so it become a such. ... > struct sprd_eic *sprd_eic; > struct resource *res; > int ret, i; > + u16 num_banks = 0; Preserve reversed xmas tree ordering. ... > @@ -630,10 +631,12 @@ static int sprd_eic_probe(struct platform_device *pdev) > sprd_eic->chip.set = sprd_eic_set; > fallthrough; > case SPRD_EIC_ASYNC: > + fallthrough; > case SPRD_EIC_SYNC: > sprd_eic->chip.get = sprd_eic_get; > break; > case SPRD_EIC_LATCH: > + fallthrough; > default: > break; Pointless changes. And actually create the code less maintainable. -- With Best Regards, Andy Shevchenko
