On Thu, Aug 03, 2023 at 10:05:51AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > Add comments about workaround used to configure membase address. This > follows suggestions made during review of a sc16is7xx driver patch to > add the same workaround. > > Link: https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@xxxxxxxxxxxxxxx > Link: https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@xxxxxxxxxxx/ > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > --- > drivers/tty/serial/max310x.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c > index 416d553b73a7..5903dd033fd0 100644 > --- a/drivers/tty/serial/max310x.c > +++ b/drivers/tty/serial/max310x.c > @@ -1369,6 +1369,11 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty > s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY; > s->p[i].port.iotype = UPIO_PORT; > s->p[i].port.iobase = i; > + /* > + * Use all ones as membase to make sure uart_configure_port() in > + * serial_core.c does not abort for SPI/I2C devices where the > + * membase address is not applicable. > + */ > s->p[i].port.membase = (void __iomem *)~0; > s->p[i].port.uartclk = uartclk; > s->p[i].port.rs485_config = max310x_rs485_config; > > base-commit: 426263d5fb400ccde5444748693dc75bda18f01e > -- > 2.30.2 > Meta-comment, your email system is not correct and is not able to be verified as I get the following when attempting to apply your patch: --- ✗ [PATCH] serial: max310x: add comments for membase address workaround --- ✗ BADSIG: DKIM/hugovil.com Please fix up for future submissions. thanks, greg k-h
