Re: [PATCH v3] tty: vt: Remove some repetitive initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02. 08. 23, 4:20, oushixiong wrote:
Members vc_col, vc_rows and vc_size_row of the struct vc_data have been
initialized in visual_init(), so it no longer to initialized them again
in vc_init().

The patch looks correct to me. The duplicated code comes from some 1.x era.

The part after the comma should be something like:
"so it is no longer needed to initialize them in vc_init() again."

Signed-off-by: oushixiong <oushixiong@xxxxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

thanks,
--
js
suse labs




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux