Re: [PATCH 2/2] net: nfc: remove casts from tty->disc_data

To: Jakub Kicinski <kuba@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] net: nfc: remove casts from tty->disc_data
From: Jiri Slaby <jirislaby@xxxxxxxxxx>
Date: Thu, 3 Aug 2023 07:08:07 +0200
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Max Staudt <max@xxxxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
In-reply-to: <20230802120755.10849c9a@kernel.org>
References: <20230801062237.2687-1-jirislaby@kernel.org> <20230801062237.2687-3-jirislaby@kernel.org> <20230802120755.10849c9a@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1

On 02. 08. 23, 21:07, Jakub Kicinski wrote:

On Tue,  1 Aug 2023 08:22:37 +0200 Jiri Slaby (SUSE) wrote:

tty->disc_data is 'void *', so there is no need to cast from that.
Therefore remove the casts and assign the pointer directly.


Which tree are these expected to flow thru?

The intention was through the tty tree. But I don't mind either way --it's up to you Greg.


thanks,
--
js
suse labs

Follow-Ups:
- Re: [PATCH 2/2] net: nfc: remove casts from tty->disc_data
  - From: Greg KH

References:
- [PATCH 0/2] tty: remove casts from tty->disc_data
  - From: Jiri Slaby (SUSE)
- [PATCH 2/2] net: nfc: remove casts from tty->disc_data
  - From: Jiri Slaby (SUSE)
- Re: [PATCH 2/2] net: nfc: remove casts from tty->disc_data
  - From: Jakub Kicinski