Re: [PATCH 1/2] can: can327: remove casts from tty->disc_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Jiri Slaby (SUSE)" <jirislaby@xxxxxxxxxx>, gregkh@xxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/2] can: can327: remove casts from tty->disc_data
From: Max Staudt <max@xxxxxxxxx>
Date: Tue, 1 Aug 2023 22:46:03 +0900
Cc: linux-serial@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
In-reply-to: <20230801062237.2687-2-jirislaby@kernel.org>
References: <20230801062237.2687-1-jirislaby@kernel.org> <20230801062237.2687-2-jirislaby@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 8/1/23 15:22, Jiri Slaby (SUSE) wrote:

tty->disc_data is 'void *', so there is no need to cast from that.
Therefore remove the casts and assign the pointer directly.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>


Thanks for spotting this!

Reviewed-by: Max Staudt <max@xxxxxxxxx>

References:
- [PATCH 0/2] tty: remove casts from tty->disc_data
  - From: Jiri Slaby (SUSE)
- [PATCH 1/2] can: can327: remove casts from tty->disc_data
  - From: Jiri Slaby (SUSE)

Prev by Date: Re: [PATCH v2] tty: vt: Remove some repetitive initialization
Next by Date: Re: [PATCH 2/2] net: nfc: remove casts from tty->disc_data
Previous by thread: Re: [PATCH 1/2] can: can327: remove casts from tty->disc_data
Next by thread: [PATCH 2/2] net: nfc: remove casts from tty->disc_data
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]