Wed, Jul 05, 2023 at 01:15:14PM +0000, Rodríguez Barbarin, José Javier kirjoitti: > The UART ports created by this driver were not usable out of > the box, so let the configuration be handled by the 8250 UART > subsystem. This makes the implementation simpler and the UART > port more usable. > > The 8250 UART subsystem will take care of requesting the memory > resources, but the driver needs to first read the register where > the num ports is set, so a request of the resource is needed > before registering the UART port. I see this is already pending to the next cylce, but formally I would like to NAK this change as explained in reply to cover letter why. ... Side note: > uart.port.mapbase = (unsigned long) mem->start > + data->offset[i]; Weird indentation and strange casting. -- With Best Regards, Andy Shevchenko
