gregkh@xxxxxxxxxxxxxxxxxxx, jirislaby@xxxxxxxxxx,
linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx、
luoruihong@xxxxxxxxxx,
weipengliang@xxxxxxxxxx,
wengjinfei@xxxxxxxxxx
Subject: Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF
register
In-Reply-To: <ZLArgoe3TXF27gsE@xxxxxxxxxxxxxxxxxx>
On Thu, Jul 13, 2023 at 07:51:14PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 13, 2023 at 08:42:36AM +0800, Ruihong Luo wrote:
> > Preserve the original value of the Divisor Latch Fraction (DLF) register.
> > When the DLF register is modified without preservation, it can disrupt
> > the baudrate settings established by firmware or bootloader, leading to
> > data corruption and the generation of unreadable or distorted characters.
>
> You forgot to add my tag. Why? Do you think the name of variable warrants this?
> Whatever,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Next time if you don't pick up somebody's tag, care to explain in the changelog
> why.
>
> > Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> > Signed-off-by: Ruihong Luo <colorsu1922@xxxxxxxxx>
I'm sorry, I didn't know about this rule. Thank you for helping me add
the missing tags back and for all your previous kind assistance.
--
Best Regards,
Ruihong Luo
