On Wed, Jul 12, 2023 at 10:18:03AM +0200, Jiri Slaby (SUSE) wrote: > The passed parameter to sysrq handlers is a key (a character). So change > the type from 'int' to 'u8'. Let it specifically be 'u8' for two > reasons: > * unsigned: unsigned values come from the upper layers (devices) and the > tty layer assumes unsigned on most places, and > * 8-bit: as that what's supposed to be one day in all the layers built > on the top of tty. (Currently, we use mostly 'unsigned char' and > somewhere still only 'char'. (But that also translates to the former > thanks to -funsigned-char.)) > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> > <snip> > Cc: Jason Wessel <jason.wessel@xxxxxxxxxxxxx> > Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> For kgdb: Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
