Re: [PATCH] serial: atmel: don't enable IRQs prematurely

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19. 06. 23, 13:47, Dan Carpenter wrote:
On Mon, Jun 19, 2023 at 02:44:11PM +0300, Dan Carpenter wrote:
On Mon, Jun 19, 2023 at 01:01:49PM +0200, Jiri Slaby wrote:
On 19. 06. 23, 11:45, Dan Carpenter wrote:
The atmel_complete_tx_dma() function disables IRQs at the start
of the function by calling spin_lock_irqsave(&port->lock, flags);
There is no need to disable them a second time using the
spin_lock_irq() function and, in fact, doing so is a bug because
it will enable IRQs prematurely when we call spin_unlock_irq().

Just use spin_lock/unlock() instead without disabling or enabling
IRQs.

Maybe I should add a "a second time".

"Just use spin_lock/unlock() instead without disabling or enabling
IRQs a second time."

No, I'm just stupid and I apparently fail to understand written text at times.

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

thanks,
--
js
suse labs




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux