On Wed, May 31, 2023 at 08:46:08AM +0200, Uwe Kleine-König wrote:
> uart_write() was introduced as a helper function that is for now only
> used in omap8250_soft_reset(). The latter function is only defined if
> CONFIG_PM is enabled. So add __maybe_unused to the defintion of the
> former function to fix
>
> drivers/tty/serial/8250/8250_omap.c:169:13: error: ‘uart_write’ defined but not used [-Werror=unused-function]
>
> for CONFIG_PM=n builds.
>
> Fixes: 398cecc24846 ("serial: 8250: omap: Fix imprecise external abort for omap_8250_pm()")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Hello,
>
> the offending commit is in tty-next.
Ah, there is already a fix in tty-testing, i.e. 458ab5b47d9c ("serial:
8250: omap: Move uart_write() inside PM section")
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
