On Tue, May 30, 2023 at 01:38:42PM +0200, Krzysztof Kozlowski wrote: > On 30/05/2023 12:13, Francesco Dolcini wrote: > > On Sat, May 27, 2023 at 11:49:17AM +0530, Vignesh Raghavendra wrote: > >> On 19/05/23 9:39 pm, Francesco Dolcini wrote: > >>> I would be inclined to send the following patch, do you agree? > >>> > >>> diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml > >>> index eb3488d8f9ee..e634e98aa994 100644 > >>> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml > >>> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml > >>> @@ -70,6 +70,7 @@ properties: > >>> dsr-gpios: true > >>> rng-gpios: true > >>> dcd-gpios: true > >>> + rs485-rts-active-low: true > >> > >> I believe you mean rs485-rts-active-high here > > whoops, yes of course. > > Yes, with a Fixes tag. Ack > >>> rts-gpio: true > >>> power-domains: true > >>> clock-frequency: true > >>> > >>> [1] https://lore.kernel.org/all/ZBItlBhzo+YETcJO@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > >>> > >> > >> Also, I hope you are using 8250_ompa.c and not omap-serial.c for newer > >> designs. omap-serial.c is mostly there to support legacy SoCs and not to > >> be used with K3 SoCs. > > > > Thanks for this head-up. This confused myself, while the issue I > > reported here is real, it does affect only omap-serial.c. In my case I > > am using 8250_omap.c and I can just omit the property from the DTS as > > generally expected! > > OK. Are you going send a fix for original issue? I'll do it, thanks!
