On Wed, May 17, 2023 at 05:56:55PM +0200, D. Starke wrote: > From: Daniel Starke <daniel.starke@xxxxxxxxxxx> > > Currently, changing the parameters of a DLCI gives no direct control to the > user whether this should trigger a channel reset or not. The decision is > solely made by the driver based on the assumption which parameter changes > are compatible or not. Therefore, the user has no means to perform an > automatic channel reset after parameter configuration for non-conflicting > changes. > > Add the parameter 'flags' to 'gsm_dlci_config' to force a channel reset > after ioctl setting regardless of whether the changes made require this or > not by setting this to 'GSM_FL_RESTART'. > > Note that 'GSM_FL_RESTART' is currently the only allow flag to allow > additions here. > > Signed-off-by: Daniel Starke <daniel.starke@xxxxxxxxxxx> > --- > drivers/tty/n_gsm.c | 4 ++++ > include/uapi/linux/gsmmux.h | 15 ++++++++++++++- > 2 files changed, 18 insertions(+), 1 deletion(-) > > v4 -> v5: > Changed GSM_FL_RESTART comment to be more specific about its use as > suggested in the review comment. > > Please note that I cannot response to emails until August 7th. Felix Haase > will take over from our side for questions regarding this patch series or > the n_gsm. > > Link: https://lore.kernel.org/all/DB9PR10MB5881B63FBBA7912DF5A7A6A8E0789@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ Ok, I'll wait for a resend by Felix to consider these as having someone be responsible for them if they cause problems is key :) thanks, greg k-h
