On Thu, 25 May 2023 16:37:17 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Thu, May 25, 2023 at 4:26 PM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote: > > On Thu, 25 May 2023 13:27:52 +0300 > > andy.shevchenko@xxxxxxxxx wrote: > > > Thu, May 25, 2023 at 12:03:13AM -0400, Hugo Villeneuve kirjoitti: > > > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > > > > > Hello, > > > > this patch series mainly fixes a GPIO regression and improve RS485 flags and properties > > > > detection from DT. > > > > > > > > It now also includes various small fixes and improvements that were previously > > > > sent as separate patches, but that made testing everything difficult. > > > > > > > Patches 1 and 2 are simple comments fix/improvements. > > > > > > Usually we put fixes at the beginning of the series, but these patches are > > > missing Fixed tag. Are they really fixes or can be simply moved to the end of > > > the series? > > > > these are not code fixes, they are comments improvements. I was not aware that you need to put a Fixes tag for correcting syntax errors in comments, or adding comments to improve clarity. > > > > I often submit such comments patches but was never asked to put a Fixes tag before. Seems strange to me... > > In this case there are probably no conflicts, but the usual grouping > of patches is following > 1) fixes that may be backported; > 2) cleanups / refactoring /etc; > 3) new features. > 4) additional light-weit cleanups, such as whitespace cleaning (it's a > radical, we probably do not accept pure whitespace cleaning patches, > but you got the idea). > > Seems patches 1 and 2 fall into category 4). Ok, I changed the order to put these two patches at the end. Hugo.
