On Mon, 8 May 2023, Jacky Huang wrote: > From: Jacky Huang <ychuang3@xxxxxxxxxxx> > > This driver supports individual IP reset for ma35d1. The reset > control registers is a subset of system control registers. registers are > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx> > --- > diff --git a/drivers/reset/reset-ma35d1.c b/drivers/reset/reset-ma35d1.c > new file mode 100644 > index 000000000000..19ed323981df > --- /dev/null > +++ b/drivers/reset/reset-ma35d1.c > @@ -0,0 +1,234 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2023 Nuvoton Technology Corp. > + * Author: Chi-Fang Li <cfli0@xxxxxxxxxxx> > + */ > + > +#include <linux/bits.h> > +#include <linux/container_of.h> > +#include <linux/device.h> > +#include <linux/err.h> > +#include <linux/io.h> > +#include <linux/kernel.h> > +#include <linux/of.h> > +#include <linux/platform_device.h> > +#include <linux/reboot.h> > +#include <linux/reset-controller.h> > +#include <linux/spinlock.h> > +#include <dt-bindings/reset/nuvoton,ma35d1-reset.h> > + > +struct ma35d1_reset_data { > + struct reset_controller_dev rcdev; > + struct notifier_block restart_handler; > + void __iomem *base; > + spinlock_t lock; Please add a comment about what this protects. After adding that, feel free to add also: Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> -- i.