Re: [PATCH 2/2] serial: 8250_bcm7271: fix leak in `brcmuart_probe`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 27/04/2023 à 20:19, Doug Berger a écrit :
Smatch reports:
drivers/tty/serial/8250/8250_bcm7271.c:1120 brcmuart_probe() warn:
'baud_mux_clk' from clk_prepare_enable() not released on lines: 1032.

The issue is fixed by using a managed clock.

Fixes: 41a469482de2 ("serial: 8250: Add new 8250-core based Broadcom STB driver")
Reported-by: XuDong Liu <m202071377@xxxxxxxxxxx>
Link: https://lore.kernel.org/lkml/20230424125100.4783-1-m202071377@xxxxxxxxxxx/
Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
---
  drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index 90ee7bc12f77..af0e1c070187 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -1012,7 +1012,7 @@ static int brcmuart_probe(struct platform_device *pdev)
  	of_property_read_u32(np, "clock-frequency", &clk_rate);
/* See if a Baud clock has been specified */
-	baud_mux_clk = of_clk_get_by_name(np, "sw_baud");
+	baud_mux_clk = devm_clk_get(dev, "sw_baud");

If switching to devm_clk_get(), maybe devm_clk_get_enabled() could also be an option to fix both issues and avoid adding some LoC.

The order of operation in the remove function would then be different. I don't know if it can be an issue.

Just my 2c.

CJ

  	if (IS_ERR(baud_mux_clk)) {
  		if (PTR_ERR(baud_mux_clk) == -EPROBE_DEFER) {
  			ret = -EPROBE_DEFER;




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux