Re: [PATCH v8 10/11] tty: serial: Add Nuvoton ma35d1 serial driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jacky,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on clk/clk-next linus/master v6.3 next-20230424]
[cannot apply to pza/reset/next pza/imx-drm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacky-Huang/arm64-Kconfig-platforms-Add-config-for-Nuvoton-MA35-platform/20230425-182746
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230425102418.185783-11-ychuang570808%40gmail.com
patch subject: [PATCH v8 10/11] tty: serial: Add Nuvoton ma35d1 serial driver support
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230425/202304252118.P0ZCvlQO-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9f299bce6e0e871aa112e06e2451e88198a75d97
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jacky-Huang/arm64-Kconfig-platforms-Add-config-for-Nuvoton-MA35-platform/20230425-182746
        git checkout 9f299bce6e0e871aa112e06e2451e88198a75d97
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/tty/serial/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304252118.P0ZCvlQO-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/tty/serial/ma35d1_serial.c: In function 'ma35d1serial_probe':
   drivers/tty/serial/ma35d1_serial.c:675:28: error: implicit declaration of function 'devm_ioremap'; did you mean 'of_ioremap'? [-Werror=implicit-function-declaration]
     675 |         up->port.membase = devm_ioremap(&pdev->dev, up->port.iobase, UART_REG_SIZE);
         |                            ^~~~~~~~~~~~
         |                            of_ioremap
>> drivers/tty/serial/ma35d1_serial.c:675:26: warning: assignment to 'unsigned char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     675 |         up->port.membase = devm_ioremap(&pdev->dev, up->port.iobase, UART_REG_SIZE);
         |                          ^
   cc1: some warnings being treated as errors


vim +675 drivers/tty/serial/ma35d1_serial.c

   647	
   648	/*
   649	 * Register a set of serial devices attached to a platform device.
   650	 * The list is terminated with a zero flags entry, which means we expect
   651	 * all entries to have at least UPF_BOOT_AUTOCONF set.
   652	 */
   653	static int ma35d1serial_probe(struct platform_device *pdev)
   654	{
   655		struct resource *res_mem;
   656		struct uart_ma35d1_port *up;
   657		int ret = 0;
   658		struct clk *clk;
   659		int err;
   660	
   661		if (pdev->dev.of_node) {
   662			ret = of_alias_get_id(pdev->dev.of_node, "serial");
   663			if (ret < 0) {
   664				dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
   665				return ret;
   666			}
   667		}
   668		up = &ma35d1serial_ports[ret];
   669		up->port.line = ret;
   670		res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   671		if (!res_mem)
   672			return -ENODEV;
   673	
   674		up->port.iobase = res_mem->start;
 > 675		up->port.membase = devm_ioremap(&pdev->dev, up->port.iobase, UART_REG_SIZE);
   676		up->port.ops = &ma35d1serial_ops;
   677	
   678		spin_lock_init(&up->port.lock);
   679	
   680		clk = of_clk_get(pdev->dev.of_node, 0);
   681		if (IS_ERR(clk)) {
   682			err = PTR_ERR(clk);
   683			dev_err(&pdev->dev, "failed to get core clk: %d\n", err);
   684			return -ENOENT;
   685		}
   686	
   687		err = clk_prepare_enable(clk);
   688		if (err)
   689			return -ENOENT;
   690	
   691		if (up->port.line != 0)
   692			up->port.uartclk = clk_get_rate(clk);
   693	
   694		ret = platform_get_irq(pdev, 0);
   695		if (ret < 0)
   696			return ret;
   697		up->port.irq = ret;
   698		up->port.dev = &pdev->dev;
   699		up->port.flags = UPF_BOOT_AUTOCONF;
   700	
   701		platform_set_drvdata(pdev, up);
   702	
   703		return uart_add_one_port(&ma35d1serial_reg, &up->port);
   704	}
   705	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux