On Thu, Apr 13, 2023 at 04:44:20PM -0500, Andrew Davis wrote: > The EXAR_DEVICE macro was converted to use PCI_DEVICE_DATA, having > this macro at doesn't add much, remove it. I'm not against this, but I have to point out that this patch brings inconsistency into the table. Either convert all, or none, I think. That's why the patch that converts EXAR_DEVICE() to use PCI_DEVICE_DATA() had a little intrusion. -- With Best Regards, Andy Shevchenko