Dne torek, 21. marec 2023 ob 22:56:17 CEST je Cristian Ciocaltea napisal(a):
> Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma &
> dma-names properties") documented dma-names property to handle Allwinner
> D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the
> reverse of what a bunch of different boards expect.
>
> The initial proposed solution was to allow a flexible dma-names order in
> the binding, due to potential ABI breakage concerns after fixing the DTS
> files. But luckily the Allwinner boards are not affected, since they are
> using a shared DMA channel for rx and tx.
>
> Hence, the first step in fixing the inconsistency was to change
> dma-names order in the binding to tx->rx.
>
> Do the same for the snps,dw-apb-uart nodes in the DTS file.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
> ---
Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
Best regards,
Jernej
> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> b/arch/arm/boot/dts/sun8i-a23-a33.dtsi index f630ab55bb6a..4aa9d88c9ea3
> 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -490,7 +490,7 @@ uart0: serial@1c28000 {
> clocks = <&ccu CLK_BUS_UART0>;
> resets = <&ccu RST_BUS_UART0>;
> dmas = <&dma 6>, <&dma 6>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -503,7 +503,7 @@ uart1: serial@1c28400 {
> clocks = <&ccu CLK_BUS_UART1>;
> resets = <&ccu RST_BUS_UART1>;
> dmas = <&dma 7>, <&dma 7>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -516,7 +516,7 @@ uart2: serial@1c28800 {
> clocks = <&ccu CLK_BUS_UART2>;
> resets = <&ccu RST_BUS_UART2>;
> dmas = <&dma 8>, <&dma 8>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -529,7 +529,7 @@ uart3: serial@1c28c00 {
> clocks = <&ccu CLK_BUS_UART3>;
> resets = <&ccu RST_BUS_UART3>;
> dmas = <&dma 9>, <&dma 9>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -542,7 +542,7 @@ uart4: serial@1c29000 {
> clocks = <&ccu CLK_BUS_UART4>;
> resets = <&ccu RST_BUS_UART4>;
> dmas = <&dma 10>, <&dma 10>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
