* Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [230330 12:52]: > On Thu, Mar 30, 2023 at 02:32:31PM +0300, Tony Lindgren wrote: > > * Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [230329 09:08]: > > > On Thu, Mar 23, 2023 at 09:10:47AM +0200, Tony Lindgren wrote: > > > > --- /dev/null > > > > +++ b/drivers/tty/serial/serial_base.c > > > > @@ -0,0 +1,142 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > > > Given that the driver core is "GPL-2.0-only", why is this -or-later? > > > > Thanks for noticing, the intention was to set it to what serial_core.c has: > > > > $ git grep -e SPDX -e MODULE_LICENSE drivers/tty/serial/serial_core.c > > drivers/tty/serial/serial_core.c:// SPDX-License-Identifier: GPL-2.0+ > > drivers/tty/serial/serial_core.c:MODULE_LICENSE("GPL"); > > Doesn't mean you have to copy it, it's your choice :) In this case my preference is to use the same as for serial_core.c. This is so folks can start moving serial port specific functions from serial_core.c to serial_port.c. And not have to worry about the possible differences with various licenses at that point :) Tony