Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v4 2/5] tty: serial: sh-sci: Fix Rx on RZ/G2L SCI
>
> On Tue, Mar 21, 2023 at 12:48 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > SCI IP on RZ/G2L alike SoCs do not need regshift compared to other SCI
> > IPs on the SH platform. Currently, it does regshift and configuring Rx
> > wrongly. Drop adding regshift for RZ/G2L alike SoCs.
> >
> > Fixes: dfc80387aefb ("serial: sh-sci: Compute the regshift value for
> > SCI ports")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v3->v4:
> > * Updated the fixes tag
> > * Replaced sci_port->is_rz_sci with dev->dev.of_node as regshift are only
> needed
> > for sh770x/sh7750/sh7760, which don't use DT yet.
> > * Dropped is_rz_sci variable from struct sci_port.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> One can wonder how this ever worked on DT-based H8/300...
Yep, it is interesting to see whether SCI ever worked on DT-based H8/300
Assuming it has same register layout as RZ/G2L SoC.
Cheers,
Biju
