+ Wolfram > Subject: RE: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler > > Hi Geert, > > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt > > handler > > > > Hi Biju, > > > > On Fri, Mar 17, 2023 at 8:59 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end > > > > interrupt handler On Thu, Mar 16, 2023 at 5:34 PM Biju Das > > <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > > > > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end > > > > > > interrupt handler > > > > > > > > > > On Thu, Mar 16, 2023 at 5:01 PM Biju Das > > > > > > <biju.das.jz@xxxxxxxxxxxxxx> > > > > wrote: > > > > > > > The RZ SCI/ RZ/A1 SCIF has only 4 interrupts. The fourth > > > > > > > interrupt is transmit end interrupt, so shuffle the > > > > > > > interrupts to fix the transmit end interrupt handler for these > IPs. > > > > > > > > > > > > > > Fixes: 392fb8df528b ("serial: sh-sci: Use > > > > > > > platform_get_irq_optional() for optional interrupts") > > > > > > > > > > > > I don't think that's the right bad commit. > > > > > > > > > > OK. I will use below commit as fixes one, that is the commit > > > > > which added RZ/A1 SCIF with 4 interrupts. > > > > > > > > > > commit 8b0bbd956228ae87 ("serial: sh-sci: Add support for > > > > > R7S9210") > > > > > > > > That one added support for RZ/A2, and is also not the bad commit? > > > > > > OK will use below one, > > > > > > Fixes: 4c84c1b3acca ("ARM: shmobile: r7s72100: add scif nodes to > > > dtsi") > > > > This really starts to look like a guessing game... Beep ;-) > > Already there is a generic compatible in driver, where we started > introducing RZ/A1 SoC With 4 interrupts. So addition of this SoC has this > issue. Am I missing anything here? Wolfram, Can you please confirm transmit end interrupt handler worked for you with the commit 4c84c1b3acca ("ARM: shmobile: r7s72100: add scif nodes to dtsi") Cheers, Biju