For serdev framework, the serdev_controller device is the tty device, which is also the child device of the uart_port device. If we don't set devt property for ctrl->dev, device_find_child(uport->dev, ...) may always return NULL in uart_suspend_port() function, which prevents us from properly handling uart port suspend, so fix it here. Fixes: bed35c6dfa6a ("serdev: add a tty port controller driver") Signed-off-by: Sherry Sun <sherry.sun@xxxxxxx> --- drivers/tty/serdev/serdev-ttyport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c index bba37ab90215..c58af8141380 100644 --- a/drivers/tty/serdev/serdev-ttyport.c +++ b/drivers/tty/serdev/serdev-ttyport.c @@ -268,6 +268,7 @@ struct device *serdev_tty_port_register(struct tty_port *port, { struct serdev_controller *ctrl; struct serport *serport; + dev_t devt = MKDEV(drv->major, drv->minor_start) + idx; int ret; if (!port || !drv || !parent) @@ -282,6 +283,7 @@ struct device *serdev_tty_port_register(struct tty_port *port, serport->tty_idx = idx; serport->tty_drv = drv; + ctrl->dev.devt = devt; ctrl->ops = &ctrl_ops; port->client_ops = &client_ops; -- 2.17.1