Hi Jacky, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on clk/clk-next tty/tty-testing tty/tty-next tty/tty-linus linus/master v6.3-rc2 next-20230315] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jacky-Huang/arm64-Kconfig-platforms-Add-config-for-Nuvoton-MA35-platform/20230315-153355 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230315072902.9298-15-ychuang570808%40gmail.com patch subject: [PATCH 14/15] tty: serial: Add Nuvoton ma35d1 serial driver support config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230315/202303151754.XvPyacT7-lkp@xxxxxxxxx/config) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/064028d2f2d911398012103aef3ce8666342ddfc git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jacky-Huang/arm64-Kconfig-platforms-Add-config-for-Nuvoton-MA35-platform/20230315-153355 git checkout 064028d2f2d911398012103aef3ce8666342ddfc # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/tty/serial/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303151754.XvPyacT7-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/tty/serial/ma35d1_serial.c:672:6: warning: no previous prototype for 'ma35d1serial_suspend_port' [-Wmissing-prototypes] 672 | void ma35d1serial_suspend_port(int line) | ^~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/tty/serial/ma35d1_serial.c:681:6: warning: no previous prototype for 'ma35d1serial_resume_port' [-Wmissing-prototypes] 681 | void ma35d1serial_resume_port(int line) | ^~~~~~~~~~~~~~~~~~~~~~~~ -- >> drivers/tty/serial/ma35d1_serial.c:670: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Suspend one serial port. drivers/tty/serial/ma35d1_serial.c:679: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Resume one serial port. vim +/ma35d1serial_suspend_port +672 drivers/tty/serial/ma35d1_serial.c 668 669 /** > 670 * Suspend one serial port. 671 */ > 672 void ma35d1serial_suspend_port(int line) 673 { 674 uart_suspend_port(&ma35d1serial_reg, &ma35d1serial_ports[line].port); 675 } 676 EXPORT_SYMBOL(ma35d1serial_suspend_port); 677 678 /** 679 * Resume one serial port. 680 */ > 681 void ma35d1serial_resume_port(int line) 682 { 683 struct uart_ma35d1_port *up = &ma35d1serial_ports[line]; 684 685 uart_resume_port(&ma35d1serial_reg, &up->port); 686 } 687 EXPORT_SYMBOL(ma35d1serial_resume_port); 688 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
