Re: [PATCH] serial: imx: Drop a few unneeded casts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ilpo,

On Thu, Mar 02, 2023 at 05:35:17PM +0200, Ilpo Järvinen wrote:
> On Thu, 2 Mar 2023, Uwe Kleine-König wrote:
> 
> > There is no point in casting a struct uart_port to a struct imx_port
> > just to access the first member of the latter (a struct uart_port).
> > 
> > This introduces code changes.
> 
> I don't know what this sentence is supposed to mean (did you forgot to 
> add a negation into it)?
> 
> The code changes :-) are okay though:

Yes, I intended to write:

	This introduces no changes to the generated binary.

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Thanks.

Greg isn't in patch collecting mood currently anyhow, so I will wait a
bit before sending out a fixed patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux