Re: [PATCH v4 6/6] serial: 8250_em: Add serial8250_em_{reg_update(),out_helper()}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 17, 2023 at 02:35:16PM +0000, Biju Das wrote:
> Hi Andy,
> > Subject: Re: [PATCH v4 6/6] serial: 8250_em: Add
> > serial8250_em_{reg_update(),out_helper()}
> > On Fri, Feb 17, 2023 at 11:42:55AM +0000, Biju Das wrote:

...

> > > +	switch (off) {
> > > +	case UART_FCR_EM:
> > > +		fcr = value;
> > > +		break;
> > > +	case UART_LCR:
> > > +		lcr = value;
> > > +		break;
> > > +	case UART_MCR:
> > > +		mcr = value;
> > 
> > Missing break; statement.
> 
> OK, will fix this in next version.
> 
> The original driver has some missing breaks[1].
> So for consistency I dropped this. same for below.

I see. Perhaps you can add another patch that adds them there first?

> [1] https://elixir.bootlin.com/linux/v6.2-rc8/source/drivers/tty/serial/8250/8250_em.c#L45

> > > +	}

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux