Re: [PATCH v4 1/6] serial: 8250_em: Use dev_err_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v4 1/6] serial: 8250_em: Use dev_err_probe()
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Date: Fri, 17 Feb 2023 16:03:56 +0200
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>, Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>, linux-renesas-soc@xxxxxxxxxxxxxxx
In-reply-to: <20230217114255.226517-2-biju.das.jz@bp.renesas.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20230217114255.226517-1-biju.das.jz@bp.renesas.com> <20230217114255.226517-2-biju.das.jz@bp.renesas.com>

On Fri, Feb 17, 2023 at 11:42:50AM +0000, Biju Das wrote:
> This patch simplifies probe() by using dev_err() instead
> of dev_err_probe()

The patch does the opposite AFAICS.

> and added a local variable 'dev' to
> replace '&pdev->dev'.

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- RE: [PATCH v4 1/6] serial: 8250_em: Use dev_err_probe()
  - From: Biju Das

References:
- [PATCH v4 0/6] Update Renesas {EMMA mobile, RZ/V2M} UART Port type
  - From: Biju Das
- [PATCH v4 1/6] serial: 8250_em: Use dev_err_probe()
  - From: Biju Das

Prev by Date: RE: [PATCH v4 5/6] serial: 8250_em: Use pseudo offset for UART_FCR
Next by Date: Re: [PATCH v4 2/6] serial: 8250_em: Drop slab.h
Previous by thread: [PATCH v4 1/6] serial: 8250_em: Use dev_err_probe()
Next by thread: RE: [PATCH v4 1/6] serial: 8250_em: Use dev_err_probe()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]