Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>
Subject: Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
From: Jiri Slaby <jirislaby@xxxxxxxxxx>
Date: Mon, 13 Feb 2023 10:32:58 +0100
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-serial <linux-serial@xxxxxxxxxxxxxxx>, Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>, "linux-renesas-soc@xxxxxxxxxxxxxxx" <linux-renesas-soc@xxxxxxxxxxxxxxx>
In-reply-to: <OS0PR01MB592210E15CD943F1987316F086DD9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20230210203439.174913-1-biju.das.jz@bp.renesas.com> <20230210203439.174913-4-biju.das.jz@bp.renesas.com> <56b431df-be7f-474c-8cf5-30c2eaa2745a@linux.intel.com> <OS0PR01MB5922A860B77A9BC0C9E5E3AC86DD9@OS0PR01MB5922.jpnprd01.prod.outlook.com> <cc7f4d69-7e68-0d0a-4b89-c4e16dff716b@kernel.org> <56c8fdab-a037-ea00-d83e-f75c92566d92@kernel.org> <f10bcddd-2905-3f63-dd0a-8424798932dc@kernel.org> <OS0PR01MB592210E15CD943F1987316F086DD9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 13. 02. 23, 10:31, Biju Das wrote:

So looks like similar to other macros, UART_FCR_EM (0x3) is sensible one.

UART_FCR_RO_OFFSET (9)
UART_FCR_RO_EM (UART_FCR_EM + UART_FCR_RO_OFFSET)


static unsigned int serial8250_em_serial_in(struct uart_port *p, int offset)
case UART_FCR_RO_EM:
	return readl(p->membase + (offset - UART_FCR_RO_OFFSET << 2));



Please send a complete patch as a reply. I am completely lost now.

--
js
suse labs

Follow-Ups:
- RE: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Biju Das

References:
- [PATCH v3 0/3] Update Renesas RZ/V2M UART Port type
  - From: Biju Das
- [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Biju Das
- Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Ilpo Järvinen
- RE: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Biju Das
- Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Jiri Slaby
- Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Jiri Slaby
- Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Jiri Slaby
- RE: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
  - From: Biju Das

Prev by Date: RE: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
Next by Date: Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
Previous by thread: RE: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
Next by thread: RE: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]