On Mon, Feb 06, 2023 at 10:56:10PM +0530, Kumaravel Thiagarajan wrote: > Move implementation of setup_port func() to serial8250_pci_setup_port. ... > #include "8250.h" > +#include "8250_pcilib.h" ... > +#include <linux/ioport.h> > +#include <linux/pci.h> > +#include <linux/types.h> > +#include "8250_pcilib.h" > + > +#include "8250.h" I would expect consistency as per above. -- With Best Regards, Andy Shevchenko