Re: [PATCH v11 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kumaravel Thiagarajan <kumaravel.thiagarajan@xxxxxxxxxxxxx>
Subject: Re: [PATCH v11 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon, 6 Feb 2023 13:41:22 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, jirislaby@xxxxxxxxxx, ilpo.jarvinen@xxxxxxxxxxxxxxx, macro@xxxxxxxxxxx, lukas@xxxxxxxxx, cang1@xxxxxxxxxx, matthew.gerlach@xxxxxxxxxxxxxxx, deller@xxxxxx, phil.edworthy@xxxxxxxxxxx, geert+renesas@xxxxxxxxx, marpagan@xxxxxxxxxx, u.kleine-koenig@xxxxxxxxxxxxxx, etremblay@xxxxxxxxxxxxxxxxxxxx, wander@xxxxxxxxxx, Tharun Kumar P <tharunkumar.pasumarthi@xxxxxxxxxxxxx>
In-reply-to: <Y+DnLV6Zfdy2Bz8S@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20230204053138.2520105-1-kumaravel.thiagarajan@microchip.com> <20230204053138.2520105-2-kumaravel.thiagarajan@microchip.com> <Y+DnLV6Zfdy2Bz8S@smile.fi.intel.com>

On Mon, Feb 06, 2023 at 01:40:30PM +0200, Andy Shevchenko wrote:
> On Sat, Feb 04, 2023 at 11:01:35AM +0530, Kumaravel Thiagarajan wrote:

> Ah, of course, you missed
> 
> #include "8250_pcilib.h"
> 
> here.

That said, please make sure before sending v12 that you have it compiled with
`make W=1 ...`.

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH v11 tty-next 0/4] serial: 8250_pci1xxxx: Add driver for the pci1xxxx's quad-uart function
  - From: Kumaravel Thiagarajan
- [PATCH v11 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c
  - From: Kumaravel Thiagarajan
- Re: [PATCH v11 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v11 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c
Next by Date: [PATCH v4 3/4] tty: n_gsm: add RING/CD control support
Previous by thread: Re: [PATCH v11 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c
Next by thread: [PATCH v11 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]