On 01/02/2023 03:44, Alexey V. Vissarionov wrote:
> serial: samsung: fix buffer size for clk_name
This does not belong here.
>
> Although very unlikely, the 'clk_num' value may be as big as
> 2**32 - 1 (uint32_max), so the buffer should have enough
> space for storing "clk_uart_baud4294967295\0".
> Also, the numbers in clk_name are expected to be unsigned.
>
> Found by ALT Linux Team (altlinux.org) and Linux Verification
> Center (linuxtesting.org) using SVACE.
>
> Signed-off-by: Alexey V. Vissarionov <gremlin@xxxxxxxxxxxx>
> Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup")
How did you address my comments? the clk_num cannot be beig as 2^32-1.
It's not possible, if I understand correctly.
>
> ---
>
> On 2023-01-19 15:52:38 +0100, Greg Kroah-Hartman wrote:
>
> >> Fixes: 5f5a7a5578c58852 ("serial: samsung: switch to clkdev
> >> based clock lookup")
> > Please fix your scripts to use the proper number of SHA1 digits
> > in a Fixes: line as the documentation asks for.
>
> Done. Also added the comment to the source regarding the buffer size.
>
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 0fce856434dafd80..2c701dc7c6a37191 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1407,7 +1407,7 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level,
> *
> */
>
> -#define MAX_CLK_NAME_LENGTH 15
> +#define MAX_CLK_NAME_LENGTH 24 /* "clk_uart_baud4294967295\0" */
NAK. It's just waste of space.
Best regards,
Krzysztof
