On Mon, Jan 30, 2023 at 11:35:02PM +0530, Neeraj Sanjay Kale wrote: > Adds serdev_device_break_ctl() and an implementation for ttyport. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx> > --- > drivers/tty/serdev/core.c | 11 +++++++++++ > drivers/tty/serdev/serdev-ttyport.c | 12 ++++++++++++ > include/linux/serdev.h | 6 ++++++ > 3 files changed, 29 insertions(+) <...> > +{ > + struct serport *serport = serdev_controller_get_drvdata(ctrl); > + struct tty_struct *tty = serport->tty; > + > + if (!tty->ops->break_ctl) > + return -ENOTSUPP; Documentation/dev-tools/checkpatch.rst 429 **ENOTSUPP** 430 ENOTSUPP is not a standard error code and should be avoided in new patches. 431 EOPNOTSUPP should be used instead. 432 433 See: https://lore.kernel.org/netdev/20200510182252.GA411829@xxxxxxx/ Thanks