Re: [PATCH 05/13] dt-bindings: serial: cdsn,uart: add power-domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 1/23/23 16:12, Krzysztof Kozlowski wrote:

Few Xilinx DTS have power domains in serial node:

   zynqmp-zc1232-revA.dtb: serial@ff000000: Unevaluated properties are not allowed ('power-domains' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
---
  .../devicetree/bindings/serial/cdns,uart.yaml   | 17 ++++++++++++++---
  1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
index 0c118d5336cc..38925b79cb38 100644
--- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
+++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
@@ -9,9 +9,6 @@ title: Cadence UART Controller
  maintainers:
    - Michal Simek <michal.simek@xxxxxxxxxx>

-allOf:
-  - $ref: serial.yaml#
-
  properties:
    compatible:
      oneOf:
@@ -46,6 +43,9 @@ properties:
        port does not use this pin.
      type: boolean

+  power-domains:
+    maxItems: 1
+
  required:
    - compatible
    - reg
@@ -53,6 +53,17 @@ required:
    - clocks
    - clock-names

+allOf:
+  - $ref: serial.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: cdns,uart-r1p8
+    then:
+      properties:
+        power-domains: false
+
  unevaluatedProperties: false

  examples:
--
2.34.1


Reviewed-by: Michal Simek <michal.simek@xxxxxxx>

btw: I was running it and I have seen that properties are checked only on nodes which have status property okay. On disabled nodes properties are not checked. Is this standard behavior/setting?

Thanks,
Michal



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux