Sherry Sun <sherry.sun@xxxxxxx> writes:
>> -----Original Message-----
>> From: Sergey Organov <sorganov@xxxxxxxxx>
>> Sent: 2023年1月14日 2:44
>> To: linux-serial@xxxxxxxxxxxxxxx
>> Cc: Fabio Estevam <festevam@xxxxxxxxx>; Greg Kroah-Hartman
>> <gregkh@xxxxxxxxxxxxxxxxxxx>; Jiri Slaby <jirislaby@xxxxxxxxxx>; Richard
>> Genoud <richard.genoud@xxxxxxxxx>; Sascha Hauer
>> <s.hauer@xxxxxxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>;
>> tharvey@xxxxxxxxxxxxx; Tomasz Moń <tomasz.mon@xxxxxxxxxxxxxxx>;
>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
>> Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Sergey Organov
>> <sorganov@xxxxxxxxx>
>> Subject: [PATCH 7/8] serial: imx: use readl() to optimize FIFO reading loop
>>
>> Use readl() instead of heavier imx_uart_readl() in the Rx ISR, as we know we
>> read registers that must not be cached.
>>
>> Signed-off-by: Sergey Organov <sorganov@xxxxxxxxx>
>> ---
>> drivers/tty/serial/imx.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index
>> be00362b8b67..f4236e8995fa 100644
>> --- a/drivers/tty/serial/imx.c
>> +++ b/drivers/tty/serial/imx.c
>> @@ -890,14 +890,15 @@ static irqreturn_t __imx_uart_rxint(int irq, void
>> *dev_id)
>> struct imx_port *sport = dev_id;
>> unsigned int rx, flg;
>> struct tty_port *port = &sport->port.state->port;
>> + typeof(sport->port.membase) membase = sport->port.membase;
>> u32 usr2;
>>
>> /* If we received something, check for 0xff flood */
>> - usr2 = imx_uart_readl(sport, USR2);
>> + usr2 = readl(membase + USR2);
>> if (usr2 & USR2_RDR)
>> imx_uart_check_flood(sport, usr2);
>>
>> - while ((rx = imx_uart_readl(sport, URXD0)) & URXD_CHARRDY) {
>> + while ((rx = readl(membase + URXD0)) & URXD_CHARRDY) {
>
> Actually imx_uart_readl() only set shadow registers for UCRx and UFCR,
> for the USR2 and URXD0 that you used here, they will not be cached.
Sure, and that's why we here don't need to call imx_uart_readl(), that
only needlessly checks for shadowing, thus producing pure overhead.
Best Regards,
Sergey
