There are number of functions in tty/serial which have arguments or return types that expect/behave like bool. Likely due to them existing before bool was available, other types are used. Make conversions to bool and cleanups. v3: - moxa: Fix function signature in comment - moxa: Rearrange comment (0: off, 1: on) removal from rename change to bool change (effect is internal to the series) v2: - Call dtr/rts parameters/variables consistently "active" - Don't chain one return statement with || - Don't change function signatures to >80 chars ("while at it") - moxa: differentiated dtr and status variables Ilpo Järvinen (13): tty: Cleanup tty_port_set_initialized() bool parameter tty: Cleamup tty_port_set_suspended() bool parameter tty: Cleanup tty_port_set_active() bool parameter tty: moxa: Make local var storing tty_port_initialized() bool serial: Convert uart_{,port_}startup() init_hw param to bool tty: Convert ->carrier_raised() and callchains to bool tty: Convert ->dtr_rts() to take bool argument tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active serial: Make uart_handle_cts_change() status param bool active tty: Return bool from tty_termios_hw_change() tty/serial: Call ->dtr_rts() parameter active consistently tty: moxa: Rename dtr/rts parameters/variables to active usb/serial: Rename dtr/rts parameters/variables to active drivers/char/pcmcia/synclink_cs.c | 18 +++--- drivers/ipack/devices/ipoctal.c | 4 +- drivers/mmc/core/sdio_uart.c | 13 ++--- drivers/pps/clients/pps-ldisc.c | 6 +- drivers/s390/char/con3215.c | 4 +- drivers/staging/greybus/uart.c | 4 +- drivers/tty/amiserial.c | 12 ++-- drivers/tty/hvc/hvc_console.c | 4 +- drivers/tty/hvc/hvc_console.h | 2 +- drivers/tty/hvc/hvc_iucv.c | 6 +- drivers/tty/moxa.c | 82 ++++++++++++++-------------- drivers/tty/mxser.c | 11 ++-- drivers/tty/n_gsm.c | 16 +++--- drivers/tty/serial/imx.c | 2 +- drivers/tty/serial/max3100.c | 2 +- drivers/tty/serial/max310x.c | 3 +- drivers/tty/serial/serial_core.c | 65 +++++++++++----------- drivers/tty/serial/sunhv.c | 8 +-- drivers/tty/synclink_gt.c | 21 +++---- drivers/tty/tty_ioctl.c | 8 +-- drivers/tty/tty_port.c | 22 ++++---- drivers/usb/class/cdc-acm.c | 4 +- drivers/usb/serial/ch341.c | 11 ++-- drivers/usb/serial/console.c | 2 +- drivers/usb/serial/cp210x.c | 6 +- drivers/usb/serial/cypress_m8.c | 6 +- drivers/usb/serial/digi_acceleport.c | 6 +- drivers/usb/serial/f81232.c | 10 ++-- drivers/usb/serial/f81534.c | 4 +- drivers/usb/serial/ftdi_sio.c | 6 +- drivers/usb/serial/generic.c | 10 ++-- drivers/usb/serial/ipw.c | 8 +-- drivers/usb/serial/keyspan.c | 6 +- drivers/usb/serial/keyspan_pda.c | 4 +- drivers/usb/serial/mct_u232.c | 6 +- drivers/usb/serial/mxuport.c | 4 +- drivers/usb/serial/pl2303.c | 11 ++-- drivers/usb/serial/quatech2.c | 6 +- drivers/usb/serial/sierra.c | 6 +- drivers/usb/serial/spcp8x5.c | 11 ++-- drivers/usb/serial/ssu100.c | 6 +- drivers/usb/serial/upd78f0730.c | 8 +-- drivers/usb/serial/usb-serial.c | 8 +-- drivers/usb/serial/usb-wwan.h | 2 +- drivers/usb/serial/usb_wwan.c | 6 +- drivers/usb/serial/xr_serial.c | 8 +-- include/linux/serial_core.h | 6 +- include/linux/tty.h | 2 +- include/linux/tty_ldisc.h | 4 +- include/linux/tty_port.h | 10 ++-- include/linux/usb/serial.h | 6 +- net/bluetooth/rfcomm/tty.c | 2 +- 52 files changed, 248 insertions(+), 260 deletions(-) -- 2.30.2