On Thu, 5 Jan 2023, Jiri Slaby wrote: > On 04. 01. 23, 16:15, Ilpo Järvinen wrote: > > Convert uart_handle_cts_change() to bool which is more appropriate > > than unsigned int. > > > > Cleanup callsites from operations that are not necessary with bool. > > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > ... > > --- a/drivers/tty/serial/serial_core.c > > +++ b/drivers/tty/serial/serial_core.c > > @@ -3285,11 +3285,11 @@ EXPORT_SYMBOL_GPL(uart_handle_dcd_change); > > /** > > * uart_handle_cts_change - handle a change of clear-to-send state > > * @uport: uart_port structure for the open port > > - * @status: new clear to send status, nonzero if active > > + * @status: new clear to send status, true if active > > ANyone else having troubles to parse "new clear to send status"? I could change that into new clear-to-send status while at it. > > * > > * Caller must hold uport->lock. > > */ > > -void uart_handle_cts_change(struct uart_port *uport, unsigned int status) > > +void uart_handle_cts_change(struct uart_port *uport, bool status) > > This should be "bool active" then. Yeah. I'll change in the previous patch too which also had "status". -- i.
