On Wed, Jan 04, 2023 at 09:28:50AM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 03, 2023 at 03:39:17PM +0530, Deepak R Varma wrote: > > On Tue, Jan 03, 2023 at 10:00:48AM +0100, Jiri Slaby wrote: > > > On 26. 12. 22, 7:21, Deepak R Varma wrote: > > > > + ret = request_irq(dport->port.irq, dz_interrupt, IRQF_SHARED, "dz", mux); > > > > > > How is this related to the above described change? > > > > No, it is not. My apologies. I must have joined the lines for improved readability > > and forgot to revert. I will restore this in next revision based on the feedback > > on the other patch of this series. OR I can include this change in the current > > change log as a "while at it..." statement. Would you advise me? > > NEVER have a "while at it..." change as part of a commit unless it is > relevant to the main change being made. You know better... Sounds very good. Thank you for the advise. I will revert the change in the next revision. Thank you, ./drv > > thanks, > > greg k-h
