Re: [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03. 01. 23, 12:02, lizhe wrote:
	in linflex_config_port() the member variable will be
	assigned again . see linflex_config_port()

Fine, but can you make the subject and the commit message a little bit saner?

I.e. no tabs, no spaces before semicolons and colons. The subject should be something like "serial: linflexuart: remove redundant uart type _assignment_" and so on.

Signed-off-by: lizhe <sensor1010@xxxxxxx>

Is this your legal name?

---
  drivers/tty/serial/fsl_linflexuart.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 6fc21b6684e6..34400cc6ac7f 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
  		return PTR_ERR(sport->membase);
sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
  	sport->iotype = UPIO_MEM;
  	sport->irq = platform_get_irq(pdev, 0);
  	sport->ops = &linflex_pops;

--
js
suse labs




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux