Re: [PATCH v2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq_guard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 24, 2022 at 09:37:43AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Dec 24, 2022 at 01:47:12PM +0530, Deepak R Varma wrote:
> > The refcount_* APIs are designed to address known issues with the
> > atomic_t APIs for reference counting. They provide following distinct
> > advantages:
> >    - protect the reference counters from overflow/underflow
> >    - avoid use-after-free errors
> >    - provide improved memory ordering guarantee schemes
> >    - neater and safer.
> > Hence, replace the atomic_* APIs by their equivalent refcount_t
> > API functions.
> >
> > This patch proposal address the following warnings generated by
> > the atomic_as_refcounter.cocci coccinelle script
> > atomic_add_return(-1, ...)
> >
> > Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
> > ---
>
> This depends on the previous patch you sent, so why wasn't this a patch
> series?  Always send patches as a series, otherwise I would have
> attempted to apply this one first and it would have failed.  You will
> recieve 0-day reports about that happening over the next few days as our
> testing infrastructure will also be confused.

My apologies. I will send in the patches in a series and highlight the
dependency as well. Sorry.

./drv

>
> Please fix and resend all changes you wish to have done to this driver
> together.
>
> thanks,
>
> greg k-h





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux